Remove spirv result from Error::display #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to the lossiness of running the spirv binaries, while needing (more) consistent error output between compiled and tool.
XAMPPRocky
approved these changes
Mar 24, 2021
khyperia
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the printing of the inner spirv result from Error's Display implementation in order to more closely align the error output between tool and compiled mode. Unfortunately, this means we're losing information in compiled mode, since in that case the error code is actually "accurate", but this is due to the fact that the error code used when a tool failed was just "internalerror" since spirv binaries have no way to determine the actual inner error that caused the tool to fail.
Resolves: #19